search

Shinmera / plump

Practically Lenient and Unimpressive Markup Parser for Common Lisp
https://shinmera.github.io/plump
zlib License
119 stars 21 forks source link

Ensure correct loading of character entity references on LispWorks #23

Closed elrzn closed 4 years ago

elrzn commented 4 years ago

The library fails to load as LispWorks cannot cope with the contents of *entity-map*.

Adding the encoding option to the source file fixes this, both when loading and editing the file. I am not aware of a less intrusive way to fix this.

This commit hopefully fixes issue #18. Tested on LispWorks 7.1.2 64bit on macOS.

Shinmera commented 4 years ago

Can you try changing line 19 in plump.asd to be (:file "entities" :encoding :utf-8) instead of your patch?

LispWorks refuses to run on my system so I currently don't have an easy way to test, myself.

elrzn commented 4 years ago

I tried that first, but it didn't fix anything. I went the other route after reading this related issue https://github.com/marcoheisig/Petalisp/issues/1

Shinmera commented 4 years ago

Do you have a support contract with LispWorks? This seems like a problem in how they compile things, or in the very least a problem with how ASDF works on their implementation.

elrzn commented 4 years ago

Hi Shinmera, sorry for the delay.

It turns out this was indeed an issue with ASDF: https://bugs.launchpad.net/asdf/+bug/1766618

LispWorks users can either upgrade themselves to ASDF >3.3.2.7 (the bundled version is 3.3.0) or doing (pushnew :asdf-unicode *features*) before calling Quicklisp or ASDF.

I will close this PR and comment on the related issue. Thank you for your time.