Closed Nixill closed 2 months ago
Those look great!
The only one I'm a bit concerned about is the third one, It might not be clear enough especially when put compared to the taps. Maybe something like this could be clearer?
I'd happily merge a PR if you can submit one according to the contribution guidelines in any case.
Updated! I agree, the "..." isn't very clear. While I was at it I decided to switch the plain oval for the empty keycap already available in the font, modified to better fit the dimensions.
They're also now sorted below by filename, which I would suggest as action/press-end.svg
, action/press-long.svg
, action/press-start.svg
, action/tap-double.svg
, and action/tap-single.svg
. If you don't want to create a new folder, I suppose they fit as icons (so icon/action-
instead of action/
).
I actually think your oval was better since that clearly signifies the face buttons, rather than the keycap glyph you used from the keyboard set now.
This is a nice addition @StevenH237 ! Looking forward to using this in our app which has several of these features already.
6 and 7 are sorta already covered for the triggers with a pull and soft pull icon:
It would be nice to have icons for performing specific actions with a controller button.
This is Steam Input's list of which actions on a button or stick can activate a control, which I figured would be a good starting point:
Presumably, 1 can just be expressed as the lack of an action icon - but I also figured that having something that explicitly says "just tap, don't do anything else" could be neat, so I made it.
2 through 5 are also present below.
6 and 7 could possibly see a use on joysticks and triggers, but I didn't feel a need to make glyphs for those.
And 8 can just be expressed by a + between two buttons. You don't need anything special for it.
With that said, I've created glyphs for 1-5 as seen below:
Notably, single and long tap aren't quite centered in the document, but I went for consistency of the button's location compared to the other glyphs in this set for those two.