Shinmera / tooter

A Common Lisp client library for Mastodon instances.
https://shinmera.github.io/tooter
zlib License
44 stars 6 forks source link

Added other entities #18

Closed cage2 closed 4 years ago

cage2 commented 4 years ago

Hi Shinmera!

I have added all the remaining entities and updated the old ones to reflects the changes upstream.

I would lie if i would say that i extensively tested these changes, however i did a minimal testing and nothing was broken during this.

I just added new slots or entities so, hopefully, no user code should fails for that.

Sorry if this PR could appears a bit overwhelming. But i got a free afternoon and i thought would be a good idea to spend it adding the remaining entities. :)

Bye! C.

cage2 commented 4 years ago

On Sun, Apr 26, 2020 at 05:06:57AM -0700, Nicolas Hafner wrote:

Hi Shinmera!

@Shinmera requested changes on this pull request.

Looks mostly good, just some minor comments on things I noticed.

Thank you very much for reviewing this, i am going to start apply your suggestion in a minute. I hope to finish today but, if not, in the few next days.

The delay because tomorrow will start ELS but i guess you already know that! ;-) :-)

Thanks! C.

Shinmera commented 4 years ago

Your work has been excellent and I'm in no rush, so take all the time you need.

cage2 commented 4 years ago

Hi Shinmera!

I tried to decode correctly as much entities as i could, the code appear more robust to me now!

Fortunately the file to generate documentation seems was not broken as i was able to generate a nice webpage from it :)

Looking forward for your comments!

Bye! C.

Shinmera commented 4 years ago

Okey, looks fine from what I can gather. I don't have time fore a better audit right now so I'll just trust you got it right :)

cage2 commented 4 years ago

On Sun, Apr 26, 2020 at 11:03:47AM -0700, Nicolas Hafner wrote:

Hi Shinmera!

Okey, looks fine from what I can gather. I don't have time fore a better audit right now so I'll just trust you got it right :)

Thank you very much for your trust! :)

Bye! C.