search

Shinoow / AbyssalCraft

Source repo for the AbyssalCraft mod
GNU Lesser General Public License v3.0
81 stars 52 forks source link

Entity NBT being read/written with the wrong data type #512

Closed Shinoow closed 7 months ago

Shinoow commented 9 months ago

Description:

In some cases mob data saved to NBT (like whether or not a mob is a child, to name one) is saved as the wrong data type (I think the most notable one is integers being saved as bytes). Haven't done a thorough search among closed issues for the symptoms of this crashing, but it can cause crashes by the looks of it (might be in combination with another mod that ends up exposing the error).

Sample of it causing a crash in the crash report section (courtesy of Darkly Steamgear)

Solution is to just go over every entity this mod adds and correct the NBT reading/writing.

Crash report:

https://mclo.gs/JFprD2c

Affected versions ("latest" is NOT a version):

Latest log file for when the issue was present:

Shinoow commented 8 months ago

Might actually specifically be the handling on mob data regarding the mob being a child that's the root of this issue. Granted, I would still say another mod is exposing the error as with the mod alone this doesn't crash. Something is poking at the DataManager in mobs.