ShinyColorsDB / ShinyColorsDB-SpineViewer

A simple viewer to render characters in game
https://mspine.shinycolors.moe/
27 stars 6 forks source link

Do you accept PR? #7

Closed darkeroticism closed 6 months ago

darkeroticism commented 6 months ago

@alex94539 Hello. I like ShinyColors' standing pictures and would like to save them as images, so I modified main.js a little using the local overrides on the Chrome Developer Tool to make it easier to save. If possible, I would like to formally submit a PR, but are you willing to accept?

alex94539 commented 6 months ago

Of course you can submit a PR. I'll decide to accept or not depends on the context you submit. BTW "save as images" is already available on https://mspine.shinycolors.moe, maybe you'd like to try it out(?

darkeroticism commented 6 months ago

Oh, I always used https://spine.shinycolors.moe/ . Are there any differences other than the image save button?

My custom has the following four points,

and I was trying to issue a PR for the first two.

darkeroticism commented 6 months ago

Also, I like the girl's sad face, 😈 so I fixed it at the initial state of sad (0 frame) and tried to save the image, but in the initial state it stopped in the middle of the blinking animation, Not good.

桑山千雪-P_SR-【夏、イエー】桑山千雪-一般_演出服 (1)

Apparently, due to the structure of spine, there is a function(mixin) to smoothly connect motions in a program and the standing picture I wanted was a moment during the transition from normal state to sad.

I was originally thinking of an approach that would stop the motion and save it automatically, but I realized that it was impossible because the motion I wanted didn't exist. For this reason, I changed my approach to creating an image save button, but in this case I want slow motion. I would like to implement that in the future.