ShipChain / hydra

Centralized network management for decentralized networks -- helping organize and publish sidechain connection details
https://docs.shipchain.io/docs/validatorGuide.html
Apache License 2.0
8 stars 2 forks source link

Better subprocess result/error handling #12

Closed mlclay closed 4 years ago

mlclay commented 5 years ago

External calls from Hydra do not have any validation that the commands ran successfully. Hydra needs to capture the result from executing commands and check the exit codes and/or process output.

Options for handling this might include a new fail_on_error parameter which checks the exit code, or a successful_message that needs to be found in the process output.

Expected to be handled in raw_exec

https://github.com/ShipChain/hydra/blob/05078bd6c7f4087cf4c09693f72d4fcd28f269a8/hydra/helpers/__init__.py#L74