ShipChain / hydra

Centralized network management for decentralized networks -- helping organize and publish sidechain connection details
https://docs.shipchain.io/docs/validatorGuide.html
Apache License 2.0
8 stars 2 forks source link

Better subprocess error handling #39

Closed mlclay closed 4 years ago

mlclay commented 4 years ago

This fixes #12

The default behavior of binary_exec has changed to check process return code value. If a non-zero code is encountered, a CalledProcessError is raised. A new optional parameter exists to skip this behavior; binary_exec(cmd, ignore_error=True) will retain previous behavior.

The following steps were tested to ensure no existing functionality was broken with this change: