search

ShipEngine / firebase-extensions

Apache License 2.0
5 stars 7 forks source link

feat(rates,validate): add https callable functions as an alternative way to call apis #27

Closed Salakar closed 3 years ago

Salakar commented 3 years ago

This makes it simpler on frontend projects to just http call the function url and get rates back or validate an address.

Depends on #26.

andyhite commented 3 years ago

@Salakar I was OOO on Friday and just now seeing this, but it makes sense to me. I had just been thinking about this actually – the getRates and validateAddress functions don't make sense as Firestore collection triggers. I've got #26 merged and can merge this whenever you're ready.

andyhite commented 3 years ago

@Salakar is this ready to merge? It's still in draft status, so I don't want to prematurely merge it.

Salakar commented 3 years ago

It is ready sorry, I left it in draft since I wasn't sure if it would be accepted

karayu commented 3 years ago

We're doing recording now -- @andyhite might merging?

andyhite commented 3 years ago

@karayu my apologizes, I missed the last comment from @Salakar 6 days ago. Merged now. Do you want me to publish a new version of the extension to Firebase?

karayu commented 3 years ago

Yay! Thank you so much!

karayu commented 3 years ago

And yes please! new publish would be great @andyhite !

andyhite commented 3 years ago

@karayu on it now

andyhite commented 3 years ago

@karayu New versions published. I went ahead and pushed 0.0.2 version of everything just to make sure we didn't miss any tweaks.

karayu commented 3 years ago

Woo! amazing! Thank you so much

On Tue, Oct 12, 2021 at 2:11 PM Andrew Hite @.***> wrote:

@karayu https://github.com/karayu New versions published. I went ahead and pushed 0.0.2 version of everything just to make sure we didn't miss any tweaks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ShipEngine/firebase-extensions/pull/27#issuecomment-941565669, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE4GMATAX53HGOHLYNDO43UGSQB3ANCNFSM5FE7FNVQ .

-- Kara Lele Yu Product Manager - Firebase Extensions

(530) i-am-kara @.***

This email and the information it contains are confidential and may be privileged. If you have received this email in error please notify me immediately. You should not copy it for any purpose, or disclose its contents to any other person. Internet communications are not secure and, therefore, Google does not accept legal responsibility for the contents of this message as it has been transmitted over a public network. If you suspect the message may have been intercepted or amended please let me know.