search

ShipEngine / shipengine-dotnet

The official ShipEngine SDK for C# and the .NET Framework
https://www.shipengine.com/docs/
Apache License 2.0
11 stars 11 forks source link

fix: add FundingSource & ParcelGuard as valid options for InsuranceProvider #111

Closed avisser closed 1 month ago

avisser commented 1 month ago

per https://www.shipengine.com/docs/shipping/add-insurance-to-shipment/

avisser commented 1 month ago

@semarj If you wouldn't mind reviewing. This'll be my 2nd PR. How many do I need before I get a T-shirt?

avisser commented 1 month ago

@jpill Can I get this tiny change merged? I'm a paying customer trying to use Parcel Guard in my dotnet app.

avisser commented 1 month ago

Thanks!

semarj commented 1 month ago

@avisser Thank you for the submission. Can you send me an email with your address and T-shirt size? joshua.semar@auctane.com

avisser commented 1 month ago

I just tried using the new release. The new values, parcelguard and funding_source don't work in the sandbox. When I pass either value, the response has the following error

{
  "RequestId": null,
  "ErrorSource": 1,
  "ErrorType": "business_rules",
  "ErrorCode": "unspecified",
  "ResponseMessage": null,
  "TargetSite": null,
  "Message": "A shipping carrier error occurred: Wallet not found for currency USD",
  "Data": {},
  "InnerException": null,
  "HelpLink": null,
  "Source": null,
  "HResult": -2146233088,
  "StackTrace": null
}

It works in Prod, but it seems like it should work in Test/Sandbox too.

I've validated this with Postman too. Is there a better place to file server bugs?