search

ShipEngine / shipengine-dotnet

The official ShipEngine SDK for C# and the .NET Framework
https://www.shipengine.com/docs/
Apache License 2.0
11 stars 11 forks source link

ShipEngineSDK.CreateLabelFromShipmentDetails.CustomsItem and ShipEngineSDK.Common.CustomsItem appear to be identical #56

Open FenceDad opened 1 year ago

FenceDad commented 1 year ago

The two classes are identical. I use these to pass customs information when checking rates and creating labels. Can these be consolidated into one class? Preferably ShipEngineSDK.Common.CustomsItem

AnneOReilly commented 1 year ago

Hey there! Thanks for the heads up on the duplication. Just so you know, we do allow community contributions to the SDK https://github.com/ShipEngine/shipengine-dotnet#contributing

It can take us a little while to tackle issues that aren't breaking, but if you submit a PR we will look through it ASAP!

FenceDad commented 1 year ago

@AnneOReilly I see that in the documentation. We process 1000s of shipments through SE daily and it can be difficult for us to tackle these fixes on our own while maintaining our code base. We are trying to get off the old SE SDK that was published, so my apologies for the flood of open issues. If we can find the time to resolve them, we will help where we can.