ShipEngine / shipengine-dotnet

The official ShipEngine SDK for C# and the .NET Framework
https://www.shipengine.com/docs/
Apache License 2.0
11 stars 11 forks source link

feat: when enum not found, default to unspecified error code on serialization #82

Closed jpill closed 5 months ago

jpill commented 6 months ago

This change introduces a custom converter that populates a default unspecified error code if the json value cannot be found in the enumeration on serialization.

This will allow additions to be made to the error code enumeration in the ShipEngine code without immediately causing serialization exceptions here, which will help prevent unnecessary disruptions.

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8818963923

Details


Totals Coverage Status
Change from base Build 8787017493: 0.1%
Covered Lines: 661
Relevant Lines: 754

💛 - Coveralls
brock-bouchard commented 6 months ago

Is there a similar change we need to make in the other SDKs?

jpill commented 5 months ago

Is there a similar change we need to make in the other SDKs?

At the very least I'll go through and update with the current error codes we have in each, and where I can determine similar serialization may cause errors will look to account for those as well.