ShipEngine / shipengine-js

The official ShipEngine SDK for Javascript.
https://www.shipengine.com/docs/
Apache License 2.0
15 stars 10 forks source link

Create-label-from-shipment-details doesn't work with customs data #173

Closed jrogelstad closed 2 years ago

jrogelstad commented 2 years ago

Attempting to create a label from shipment data with customs info doesn't work. It throws the error "Please add a description to your customs items" even if you pass a description. This is because the map function in the code below is missing description, and description is required (even though the docs say it isn't).

https://github.com/ShipEngine/shipengine-js/blob/main/src/create-label-from-shipment-details/format-params.ts#L139

fishcharlie commented 2 years ago

Looks like this was fixed in https://github.com/ShipEngine/shipengine-js/pull/174?

jrogelstad commented 2 years ago

Yes!

fishcharlie commented 2 years ago

@jrogelstad Might wanna close it then so everything stays organized and ShipEngine can focus on active issues.