search

ShipEngine / shipengine-js

The official ShipEngine SDK for Javascript.
https://www.shipengine.com/docs/
Apache License 2.0
15 stars 10 forks source link

`Please add a description for your Customs Item(s)` Error #185

Closed fishcharlie closed 2 years ago

fishcharlie commented 2 years ago

Currently when adding custom items, the description property that a user of this SDK passes in is not attached to the request made to the ShipEngine API:

https://github.com/ShipEngine/shipengine-js/blob/9807638e770ddf253e5320a988ab4a6daca8ed70/src/get-rates-with-shipment-details/format-params.ts#L222-L232

This results in an error: Please add a description for your Customs Item(s).

Within the map function shown above there should be a description property to avoid this error from the API.

fishcharlie commented 2 years ago

It looks like https://github.com/ShipEngine/shipengine-js/issues/173 is a similar issue for create-label-from-shipment-details. However my issue pertains to get-rates-with-shipment-details.