Log4cpp - Githubissues

ShipSoft / shipdist

Recipes to build SHiP software and its dependencies

2 stars 14 forks source link

Closed olantwin closed 4 years ago

olantwin commented 4 years ago

This PR

Updated the version of log4cpp to the master of the upstream repository
Moves the configuration from the defaults to log4cpp.sh, (which were identical anyway, so there was no need to override it)
Changes the configure flags of log4cpp to be the same as other packages (i.e. take $CXX and $CXXFLAGS from the environment)

This version should play nicer with newer C++ standards, see discussion in #55 .

ThomasRuf commented 4 years ago

Did you tested it with a full build?

olantwin commented 4 years ago

I've tested this with a full build on Fedora 30. The flags are picked up correctly from the environment as well (checked using log4cpp-config).

GENIE compiles OK as well, but didn't run our genie-generator.

Log4cpp is a logging library, so as long as it builds OK, it should not change behaviour of any of our code.

Haven't built this on any other systems (yet) though.

olantwin commented 4 years ago

Maybe another comment: we don't use the static libraries, which is why I disabled their build. GENIE seems to link to the shared ones.