search

Shippable / support

Shippable SaaS customers can report issues and feature requests in this repository
101 stars 28 forks source link

"pip install" from git is broken #191

Closed thomasleveil closed 10 years ago

thomasleveil commented 10 years ago

A regression occurred lately (at least since May 13) which consistently breaks all my builds :anguished:

See build 29 as an example.

as you can see in the .travis.yml file, there is a environment variable set to git+git://github.com/BigBrotherBot/big-brother-bot.git@master#egg=b3

but once in the run_install script, this value is then git+git://github.com/BigBrotherBot/big-brother-bot.git@master#eggb3 (missing the = in #eggb3).

avinci commented 10 years ago

I think know why this is occurring. Our ENV variable parser is looking for = as a way to delimit it. And skipping it...

I am thinking of how to do this otherwise....any ideas?

avinci commented 10 years ago

@thomasleveil I have fixed this problem and deployed a patch. Please try and let me know if this works....thx for your patience

rageshkrishna commented 10 years ago

@thomasleveil I have also sent you a couple of pull requests to get your builds running on Shippable. We need to do a pip install nose so it's available in the virtualenv. Please try your builds after merging my PRs and they should run successfully on Shippable.

thomasleveil commented 10 years ago

I don't think that resolves it. There is obviously something wrong the the Shippable side as for commit 3cd9789, Travis is doing fine while Shippable fails

rageshkrishna commented 10 years ago

@thomasleveil Yes, the problem is that our python virtualenv does not come pre-installed with nosetest. As a result, when your script tries to run the tests, it falls back to the default python instance on the machine instead of the virtual environment that was configured for your build.

I got your project to run successfully on Shippable by adding nose to tests/requirements.txt. I've sent you a PR for this https://github.com/thomasleveil/b3-plugin-customcommands/pull/2

We will explore the possibility of pre-installing nosetests inside the virtual environments. In the mean time, I believe adding nose as an explicit dependency on your projects will unblock your builds on Shippable.

thomasleveil commented 10 years ago

We will explore the possibility of pre-installing nosetests inside the virtual environments.

That would be nice if you want to seduce Travis users.

In the mean time, I believe adding nose as an explicit dependency on your projects will unblock your builds on Shippable.

I guess so, but I won't do that. I'm a convinced Travis user unless a new player comes with a better offer ;) So far Travis is working for me, Shippable isn't as reliable (speed does not count when reliability is not there)

Thanks for the help so far

rageshkrishna commented 10 years ago

@thomasleveil I'm sorry you feel that way. If it's any consolation, out of the box support for nosetests will be landing in production shortly.

avinci commented 10 years ago

@thomasleveil this was a miss from us. There is no reason not to support what Travis if we claim compatibility. This has been already tested by the team and we will pushing this in the next hour. We are adding pytest, mock and nose preinstalled just like Travis.

I also want to apologize for the instability...and I hope things become more stable as Docker stabilizes also and we mature our process as a company. I really appreciate your support and feedback so far and I hope you will continue to use Shippable and help us make it better....

thomasleveil commented 10 years ago

Don't worry, there are no hard feelings here. When I added a few of my projects to Shippable it has always been for testing how good your progress was. So my projects use Travis for tests and I'm glad with that so far. Any regression or issue I experience with shippable has no consequences on my side.

I'm just glad to report the issues I met so your service can compete with Travis at some point. Competition is good :)

Feel free to clone my open source projects to add them to your internal quality tests as they seem to be good regression detectors so far ;)

Also feel free to delete and recreate my minion and rebuild the projects on my Shippable account to validate your new deployment.

rageshkrishna commented 10 years ago

@thomasleveil I have good news. The update that @avinci was referring to has been deployed. Once again, thanks for your feedback and driving us to improve our service.

thomasleveil commented 10 years ago

Everything runs as expected now. That was quick. I hope you can set up some kind of automated test to discover such regressions before us in the future ;)