search

Shiptheory / Magento-Extension

https://shiptheory.com
5 stars 4 forks source link

2 fixes and small speed optimization. #1

Closed JamesAnelay closed 8 years ago

JamesAnelay commented 8 years ago

Fixed an issue with Enterprise Sale Order Grid - the Magento Enterprise mass action block isn't called "Mage_Adminhtml_Block_Widget_Grid_Massaction" and therefore the original code didn't work so use instance of on the abstract which makes it compatable with enterprise and also allows other people to rewrite that block.

The current for order for tabs is 1. Because magento oddly uses the tab sort orders to decide which page is displated when you go to system > configuration that means your extension page is allways displayed - not the end of the world but a little annoying. Note I notice the royal mail also has a sort order of 1 so you'd need to update all of those. http://magento.stackexchange.com/questions/13197/default-tab-selection-in-system-config

I also switched out a couple of collection -> count calls to ->getSize calls - this just means that the collection doesn't need to be loaded in order to count them.

mikkelson commented 8 years ago

Thanks for your pull request, James.