search

Shipu / themevel

Theme and asset management for laravel
Creative Commons Zero v1.0 Universal
347 stars 67 forks source link

Theme trying to load when null or blanks #19

Closed dariusj18 closed 6 years ago

dariusj18 commented 6 years ago

If the active theme is configured as null or blank there doesn't seem to be any reason a theme should attempt to be loaded.

Theme [ ] not found! Maybe you're missing a theme.json file.

Shipu commented 6 years ago

every theme must be have theme.json file.

dariusj18 commented 6 years ago

That is not what I was getting at.

Currently the service throws an error if the theme does not exists, however it also considers null and blank theme names as viable theme. Ideally if the theme name is null or blank it should just not try and load a theme automatically.