Closed Trashtalk217 closed 4 years ago
I think this method would fit better in the plot component definition file itself.
What is your opinion on the docstring? Should that be a comment instead?
Yes, though I don't think a comment is needed either, the code is self-explanatory enough.
Updated it to a comment. As someone trying to learn the codebase (and having not the easiest time), I think this'll help. This may just be a me-problem however.
Looking at the patch again, I don't think the ensure-extent
is necessary. The bounds
of a layout-element
must always be an extent
already anyway.
Got a fix!
I haven't looked at the renderer codebase before this and I can't claim to understand it, but this fix does seem to work.