search

Shirakumo / alloy

A new user interface protocol and toolkit implementation
https://shirakumo.github.io/alloy
zlib License
181 stars 12 forks source link

Fixed a visual bug with the plot component. #14

Closed Trashtalk217 closed 4 years ago

Trashtalk217 commented 4 years ago

Got a fix!

I haven't looked at the renderer codebase before this and I can't claim to understand it, but this fix does seem to work.

Shinmera commented 4 years ago

I think this method would fit better in the plot component definition file itself.

Trashtalk217 commented 4 years ago

What is your opinion on the docstring? Should that be a comment instead?

Shinmera commented 4 years ago

Yes, though I don't think a comment is needed either, the code is self-explanatory enough.

Trashtalk217 commented 4 years ago

Updated it to a comment. As someone trying to learn the codebase (and having not the easiest time), I think this'll help. This may just be a me-problem however.

Shinmera commented 4 years ago

Looking at the patch again, I don't think the ensure-extent is necessary. The bounds of a layout-element must always be an extent already anyway.