Error: Trying to upload a region bigger than there is data in the image. while render tile-layer by tile-data

[tiwe0]

Hi, I am working on a game based on tilemap. I construct a tile-data.json according to the source code. But the code complains that

Trying to upload a region bigger than there is data in the image. Region is 2400 image is 1200

here is my lisp code and tile-data.json:

lisp code:

(in-package #:org.my.project)

(setf +app-system+ "dungeon")

(define-pool dungeon-asset)

(defclass main (trial:main)
  ())

(defun launch (&rest args)
  (apply #'trial:launch 'main args))

(define-asset (dungeon-asset dungeon-tile-data) tile-data #P"path/to/tiles_data.json")

(defmethod setup-scene ((main main) scene)
  (enter (make-instance 'tile-layer :tile-data (asset 'dungeon-asset 'dungeon-tile-data)) scene)
  (enter (make-instance '3d-camera :location (vec 0 0 300)) scene)
  (enter (make-instance 'render-pass) scene)
  )

tile-data.json: json

{
  "layers": [
    {
      "data": [
        3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3,4,3
      ],
      "height": 20,
      "id": 1,
      "name": "Tile Layer 1",
      "opacity": 1,
      "type": "tilelayer",
      "visible": true,
      "width": 30,
      "x": 0,
      "y": 0
    }
  ],
  "tilesets": [
    {
      "image": "tiles_prison.png",
      "name": "dungeon-map-tilesets",
      "imagewidth": 256,
      "imageheight": 256,
      "tileheight": 16,
      "tilewidth": 16,
      "firstgid": 1,
      "columns": 16
    }
  ]
}

Anything wrong?

[Shinmera]

Hi, sorry, I haven't had time to look at this until now. I'm not sure what's wrong, can you try again with the latest patches and report the error?

[tiwe0]

Hi, thanks for your reply!

• I updated the trial package using (ql:update-all-dists), but it still doesn't work with the same error.
• I cloned the repo, but there are some compiling errors.

I am using a Mac(M1). Does that matter?

Here is my test project.

dungeon_back.zip

The tilemap contains 20x30=600 tiles. For each tile, the code transforms the GID into a position (x,y). So, I understand the number 1200. But I do not understand 2400.

• when the lenght of data is less than 600, it complains:

  Trying to upload a region bigger than there is data in the image.
  Region is
  2400
  image is
  1200

• when the length of data is greater than 600, it complains:

  Invalid index 1200 for (SIMPLE-ARRAY (UNSIGNED-BYTE 8)
                        (1200)), should be a non-negative integer below 1200.

I am not familiar with OpenGL. Maybe I just made some stupid mistake.

Best wishes.

[tiwe0]

Hi, sorry to bother you again, I just noticed the patches.

Here is the error information:

  Trying to upload a region bigger than there is data in the image.
Region is:
  2400 bytes,
  0 , 0 , 0
  30 x 20 x NIL
  RGBA RGBA
image is
  UNSIGNED-BYTE bytes
  1200 , 0 , 0
  0 x 30 x 20 @ NIL
  RGBA UNSIGNED-BYTE

[tiwe0]

It seems that there is a typo in the patches on line 194 in file texture-source.lisp.

(+ off len) src-x src-y src-z src-w src-h src-d format format type
(memory-region-size region) dst-x dst-y dst-z dst-w dst-h dst-d (pixel-format texture) (pixel-type texture)))

I change it to

(+ off len) src-x src-y src-z src-w src-h src-d format type
(memory-region-size region) dst-x dst-y dst-z dst-w dst-h dst-d (pixel-format texture) format (pixel-type texture)))

Here is the error informathion again:

  Trying to upload a region bigger than there is data in the image.
Region is:
  2400 bytes,
  0 , 0 , 0
  30 x 20 x NIL
  RGBA UNSIGNED-BYTE
image is
  1200 bytes
  0 , 0 , 0
  30 x 20 x NIL @ RGBA
  RGBA UNSIGNED-BYTE

with the debuger, I found more information in upload-texture-source:

1. source:

   
   (inspect trial::source)

The object is a STRUCTURE-OBJECT of type TRIAL:TEXTURE-SOURCE.

0. PIXEL-DATA: #(2 15 3 15 2 15 3 15 2 15 3 15 ...) <- with length of 1200

1. PIXEL-TYPE: :UNSIGNED-BYTE

2. PIXEL-FORMAT: :RGBA

3. TARGET: NIL

4. LEVEL: NIL

5. SRC: (NIL NIL NIL NIL NIL NIL)

6. DST: (NIL NIL NIL NIL NIL NIL)

7. texture

   
   (inspect trial:texture)

The object is a STANDARD-OBJECT of type TRIAL:TILEMAP.

0. GENERATOR: #<TRIAL:TILE-DATA DUNGEON-ASSET/DUNGEON-TILE-DATA>
1. NAME: T
2. DEPENDENCIES: NIL
3. DATA-POINTER: NIL
4. WIDTH: 30
5. HEIGHT: 20
6. DEPTH: "unbound"
7. TARGET: :TEXTURE-2D
8. LEVELS: "unbound"
9. SAMPLES: "unbound"
10. INTERNAL-FORMAT: :RG8UI
11. SOURCES: (#)
12. MAG-FILTER: :NEAREST
13. MIN-FILTER: :NEAREST
14. MIPMAP-LEVELS: "unbound"
15. MIPMAP-LOD: "unbound"
16. ANISOTROPY: "unbound"
17. WRAPPING: "unbound"
18. BORDER-COLOR: "unbound"
19. SWIZZLE: "unbound"
20. STORAGE: "unbound"
21. PIXEL-TYPE: :UNSIGNED-BYTE
22. PIXEL-FORMAT: :RG-INTEGER
23. TILESET: #<TRIAL:TILESET 256x256 RGBA8 ALLOCATED {70099B9553}>

It seems that

for texture, len(2400) = stride(4channel) x width(30) x height(20); for source, the pixel-data is an array containing positions of each tile(1200).

Give me several days, I may figure out the solution.

[Shinmera]

df3056e7 should fix your issue.

[tiwe0]

Hi, thanks for replying!

I applied the change, but a new error was raised:

#<THREAD "main thread" RUNNING {7006360723}>:
  OpenGL signaled (1282 . INVALID-OPERATION) from TEX-SUB-IMAGE-2D.

So I reviewed the code that loads the tilemap using "tilemap.dat".

It seems that there is a typo in the patches on line 55 in the file tile-data.lisp:

:sources (list (make-image-source pixel-data width height :unsigned-byte :rg))

I changed it to:

:sources (list (make-image-source pixel-data width height :unsigned-byte :rg-integer))

And finally, it worked!

Thank you!