search

ShiromMakkad / docker-pihole-sync

A Docker Container To Sync Two Piholes
69 stars 13 forks source link

Password and DNS settings are not synced #18

Open gadgethm opened 1 year ago

gadgethm commented 1 year ago

Playing around with this for the first time, and noticed that DNS upstream settings and password are not actually synced between the two piholes.

From the code, this looks to be simply because the setupVars.conf file is being specifically excluded from the rsync command: (see https://github.com/ShiromMakkad/docker-pihole-sync/blob/master/sync-pihole.sh#L4)

Given that this file is specifically called out to be excluded, I'm guessing this is intentional. If so, the main README.md file should be updated to clarify that the settings controlled by this file are not included in the syncing.

I did also play around with removing the exclusion in my docker containers and (so far) have not experienced any ill effects. Syncing of password and DNS appears to work correctly with this change.

geekaz01d commented 1 year ago

FYI the password for pihole docker is defined in the docker configuration. The option is WEBPASSWORD.