search

Shiva-Shadowsong / loggie

A logging utility for Godot.
MIT License
45 stars 4 forks source link

Read ProjectSettings to pre-populate the logger class list #4

Closed cridenour closed 1 month ago

cridenour commented 1 month ago

I noticed my Autoloads were being labeled as (Node) and realized in the current system they could never not be (Node) since it's only looking for a class_name in the file.

After adding autoloads, I found we could read the global_class_list to pre-populate class_names and in most cases, avoid needing FileAccess unless the class is not named at all.

Shiva-Shadowsong commented 1 month ago

Sweet, I had largely copied over the class name extraction feature from LogDuck, but it always irked me that FileAccess reads were being done to achieve that. Good to see there's seems to be a better approach. I'll check it out soon.

In the meanwhile, could you make this PR towards the v1.2-dev branch instead of main?