search

ShivamKumarJha / android_tools

Bash scripts for ROM development stuff.
https://github.com/AndroidBlobs
GNU General Public License v3.0
653 stars 225 forks source link

Minor derp in dummy_dt function #27

Open GeoZac opened 2 years ago

GeoZac commented 2 years ago

When generating dummy dt, the PRODUCT_MANUFACTURER variable get sets with a minor derp https://github.com/ShivamKumarJha/android_tools/blob/483c4b426fef5c5081ca7ef2c48b333bfe110524/tools/dummy_dt.sh#L275

For instance, in the case of Xiaomi devices, it gets written as PRODUCT_MANUFACTURER := xiaomi [1] instead of PRODUCT_MANUFACTURER := Xiaomi [2]

  1. https://github.com/AndroidBlobs/device_xiaomi_surya/blob/46efa22aa8274a6d919961fa2843f831c71c0cce/lineage_surya.mk#L13
  2. https://github.com/LineageOS/android_device_xiaomi_surya/blob/4f03c8bd9cd3b51e67b815ea4eaafd8a032e811d/lineage_surya.mk#L31

on other OEMs, incorrect values gets written, eg. OnePlus