search

ShivamKumarJha / android_tools

Bash scripts for ROM development stuff.
https://github.com/AndroidBlobs
GNU General Public License v3.0
653 stars 225 forks source link

Issue #27 capitalize the brand variable for the Xiaomi brand #50

Closed prathamdby closed 6 months ago

prathamdby commented 7 months ago

Summary:

This pull request resolves Issue #27 by ensuring the correct capitalization of the brand variable for Xiaomi devices. Previously, the $BRAND variable incorrectly held the value "xiaomi" instead of the standard "Xiaomi". By adding a line in rom_vars.sh, this issue is rectified, aligning with the expected brand representation.

Changes Made:

Purpose:

The primary purpose of this pull request is to fix the capitalization inconsistency in the brand variable for Xiaomi devices. By ensuring that the $BRAND variable holds the correct capitalization, this enhancement improves code clarity and maintains consistency across the codebase, contributing to a better user experience.

How to Test:

  1. Pull the latest changes from this branch.
  2. Verify that the $BRAND variable is correctly capitalized for Xiaomi devices.
  3. Ensure that the fix does not introduce any regressions or unexpected behavior.

Related Issues:

Additional Notes:

This pull request adheres to the project's coding standards and has been tested to ensure proper functionality. Feedback and suggestions for further improvement are welcome.