search

ShivamWho / new-weather-app-react

Weather App created using ReactJS
https://newweatherappreact.netlify.app/
5 stars 26 forks source link

Animation Based On Weather #50

Closed HridoyHazard closed 2 years ago

HridoyHazard commented 2 years ago

Animation Based On Weather Such As When The Weather In Particular Area Is Rainly Then It Will Be Rainly Effect And Goes Like This For Other Weather........

HridoyHazard commented 2 years ago

assign this task to me plz

ShivamWho commented 2 years ago

@HridoyHazard there is already an issue raised for this

HridoyHazard commented 2 years ago

hi i cloned this repo and run it but the search is not working. Tried many location but it not working. can you plz check what's wrong ?? image

ShivamWho commented 2 years ago

Read CONTRIBUTING.md first

HridoyHazard commented 2 years ago

i'm not contributing man. i'm just running the project from my local directory. it not working why?

ShivamWho commented 2 years ago

you have to create an API key and add it to the .env file as I showed in CONTRIBUTING.md

HridoyHazard commented 2 years ago

hi i've added the animation.can i make a pr ? while making pr do i need to remove the .env file ??

ShivamWho commented 2 years ago

yes you can make a PR 🙂 and the .env file is in .gitignore so it will not be pushed

HridoyHazard commented 2 years ago

than you

HridoyHazard commented 2 years ago

54

here is the pr