Closed selkamand closed 7 months ago
Hi @selkamand
Thank you for this important feedback. Could you install the latest version of sigminer, as the issue should be addressed in the v2.2.1 (based on previous report at https://github.com/ShixiangWang/sigminer/discussions/432).
This update is recorded in https://github.com/ShixiangWang/sigminer/blob/master/NEWS.md#sigminer-221.
Best, Shixiang
Thanks @ShixiangWang. Working great. Apologies for the duplicate issue!
You're welcome.
Thanks for your work on this great package!
Just noticed that when a single sample MAF is supplied to sig_tally, the 'matrices' returned are not actually matrices at all, but rather are just vectors. This is inconsistent with behaviour when a multi-sample MAF is supplied (which conveniently returns a matrix with 1 row per sample and sample IDs as rownames).
Would it be possible to unify the return type irrespective of the number of samples supplied to sig_tally? (i.e. return 1-row matrices with rowname = sample identifier when single-sample MAFs are analysed)
The consistent format would make downstream analyses simpler.
Reprex is attached below
Created on 2024-01-29 by the reprex package (v2.0.1)