prompt not working with calc plugin

Shizcow / dmenu-rs

A pixel perfect port of dmenu, rewritten in Rust with extensive plugin support

GNU General Public License v3.0

200 stars 9 forks source link

prompt not working with calc plugin #4

Closed 0x85C closed 4 years ago

0x85C commented 4 years ago

Hello,

When using "-p" option to display a prompt while using --calc plugin, the prompt is used as part of the calculation, when really the prompt should be ignored in the calculator and used only for display purposes.

Examples: dmenu_run --calc -p "xyzzz" calculator breaks

dmenu_run --calc -p "22" calculator multiples everything by "4" as if "(22)" was typed first.

Shizcow commented 4 years ago

I've pushed out a temporary fix to which makes --prompt and --calc conflict to address this issue.

The next step is supporting a longer-form description of flags in plugin.yml to make these things more clear. Once this is done, this issue will be closed.

Shizcow commented 4 years ago

long_help is now supported for flags, integrated with manpage generation. A description of usage for --calc has been added to make controls more apparent to the end user.