search

Shmew / Feliz.MaterialUI

Feliz-style Fable bindings for Material-UI
https://shmew.github.io/Feliz.MaterialUI/
MIT License
70 stars 19 forks source link

Loosen paket dependencies for FSharp.Core #45

Closed Shmew closed 4 years ago

Shmew commented 4 years ago

The library generates a dependency restriction of FSharp.Core (>= 4.7.1 && < 4.8.0).

Could you adjust it like this:

nuget FSharp.Core ~> 4.7 lowest_matching: true

so that it becomes: FSharp.Core (>= 4.7.0 && < 5.0.0)

or ~> 4.7.0 lowest_matching: true if you want it to be FSharp.Core (>= 4.7.0 && < 4.8.0)?

cmeeren commented 4 years ago

Good catch! I tried your proposed change and did a dotnet paket install followed by dotnet fake build -t CiBuild, but the .nupkg that is produced still has the same restriction. Am I doing something wrong? Could you send a PR, perhaps?

cmeeren commented 4 years ago

Oh wait, I have to do a paket update, not install. Will fix.