Shmew / Feliz.MaterialUI

Feliz-style Fable bindings for Material-UI
https://shmew.github.io/Feliz.MaterialUI/
MIT License
70 stars 19 forks source link

updated to the newest material-ui v4.12 #86

Closed Linschlager closed 8 months ago

Linschlager commented 2 years ago

Resolves #85

JustinWick commented 2 years ago

Unfortunately @Shmew hasn't been active on here or Twitter since very early July 2021. It's possible something has happened to him :-/

JustinWick commented 2 years ago

Is there any way to use the updated version in this branch in a project that uses paket and yarn?

marcpiechura commented 2 years ago

Maybe we should fork it to Feliz.MUI and work on bindings for V5?

JustinWick commented 2 years ago

@Linschlager: Thoughts here?

I'd love @marcpiechura's suggestion, but at this point even just figuring out how to get this into a dependent project's package managers would unblock me :)

marcpiechura commented 2 years ago

@JustinWick . you could build the pull request branch locally and reference the dll directly, instead of the nuget package and then update the npm package separately.

halcwb commented 2 years ago

@Linschlager did you update the baseUrl? Because I think https://material-ui.com will now point to the api docs for v5. The legacy version 4 is still available at: https://v4.mui.com/.

Linschlager commented 2 years ago

@Linschlager did you update the baseUrl? Because I think https://material-ui.com will now point to the api docs for v5. The legacy version 4 is still available at: https://v4.mui.com/.

@JustinWick Yes, I did. (HtmlCache.fs in a few places) - Although I may have missed some occurrences

Maybe we should fork it to Feliz.MUI and work on bindings for V5?

@marcpiechura I think this would be the only sustainable option for moving forward. The transition to v5 should be relatively straightforward as they kept most of the structure in their docs (apart from the styling, but that's irrelevant for the transformer). When I find some time in the next week, I'll try to get a POC going on my fork

halcwb commented 2 years ago

@Linschlager I think if you change this, all references will be correct:


let refresh =
  async {
    let baseUrl = "https://v4.mui.com" //"https://material-ui.com"

...

This is in the HtmlCache.fs.

Linschlager commented 2 years ago

@Linschlager I think if you change this, all references will be correct:


let refresh =
  async {
    let baseUrl = "https://v4.mui.com" //"https://material-ui.com"

...

This is in the HtmlCache.fs.

Not fully. Common.fs also needs to fix the relative links so the crawler can fetch the files correctly

JustinWick commented 2 years ago

Any plans to continue this? I'd be using v5 now if this were available!

I'd help out, though I know less than nothing about modern JS frameworks, I'm a backend/embedded guy, the last time I got paid to make a GUI for a webpage was 20 years ago.

Linschlager commented 2 years ago

Any plans to continue this? I'd be using v5 now if this were available!

I'd help out, though I know less than nothing about modern JS frameworks, I'm a backend/embedded guy, the last time I got paid to make a GUI for a webpage was 20 years ago.

@JustinWick I have a WIP Mui5 version on my branch, though it will probably take a while for me to finalize fixing all the special cases Not sure it makes sense to publish this updated package if the end-goal is to upgrade to Mui5 anyway and a lot of things are going to change

Linschlager commented 8 months ago

Closing this in favor of the MuiV5 "PR"