search

Shmuma / ptan

PyTorch Agent Net: reinforcement learning toolkit for pytorch
MIT License
528 stars 163 forks source link

Hi Any chance of updating to PyTorch 1.0 ? #18

Open JulesVerny opened 5 years ago

JulesVerny commented 5 years ago

Hello I am finding it very difficult to install against the previous PyTorch 0.4.0, as it is now released at 1.0. Is it possible to support PyTorch 1.0 and update the code and samples ? Do we expect it to be very different or any errors ?

Observation>: When I download and run setup.py, it seems to do an install. However When I then attempt a python import ptan, I do have noetd I get an error file/home/jules/anaconda3/lib/python3.6/site-packages/ptan-0.3-py3.6.egg/ptan/common/wrapper.py ImportError:Cannot import name 'spaces' in line 6 of wrapper.py

It seems to be a problem in my environment seeing spaces within gym. Although with Anaconda I always have to set sys.path.append("/home/jules/gym") to make the gym package visible, and usable I still cannot import gym.spaces under a bash python prompt. However if I edit in VSCode, do the imports and run the python code it appears I can import ptan and run some cartpole example without errors. => So may not an Issue

Shmuma commented 5 years ago

Hi! It's in my todo list, but cannot make any time estimations, sorry

JulesVerny commented 5 years ago

No Worries - I now seem to be proceeding through the book anyway Merry Christmas