ShobiStassen / PARC

MIT License

41 stars 11 forks source link

Fix simplicial set embedding bug #26

Closed ahill187 closed 1 month ago

ahill187 commented 5 months ago

Description

The function simplicial_set_embedding from the UMAP repository has changed the required arguments, and so the PARC function run_umap_hnsw no longer works. See Issue #25.

In this PR, I have updated the arguments so that they are no longer throwing an error. In addition, I have added some tests.

ShobiStassen commented 1 month ago

@ahill187 hi Ansleigh, thanks a lot for the PR and sorry for not replying sooner - i somehow didn't actually get a notification that an issue + PR had been raised. For other fast visualization methods, i would also recommend checking out StaVia which allows you to merge/pick and choose between the graph-based and single-cell level visualizations