search

Shockah / Nickel

A modding API / mod loader for the game Cobalt Core.
Apache License 2.0
3 stars 5 forks source link

Add XML Documentation #74

Closed Fayti1703 closed 3 months ago

Fayti1703 commented 8 months ago

Massive work-in-progress. 633 Warnings on build.

Fixes #33 once completed.

Fayti1703 commented 8 months ago

@Shockah Is there a reason this property is public? It looks like an internal concern and not something that e.g. a mod would use. https://github.com/Shockah/Nickel/blob/d93cbfa6daffae8da9714e2fc6ea235065c57c1c/Nickel/NickelConstants.cs#L19-L21

Shockah commented 8 months ago

@Shockah Is there a reason this property is public? It looks like an internal concern and not something that e.g. a mod would use.

No reason, you can mark it internal instead.

Shockah commented 3 months ago

Since #33 was closed independently, I'm closing this without merging too.