search

ShogunPanda / fastify-openapi-docs

A simple plugin for Fastify that generates OpenAPI spec automatically.
ISC License
27 stars 5 forks source link

feat: Support operationId property #12

Closed fedorov-xyz closed 3 months ago

fedorov-xyz commented 3 months ago

@ShogunPanda hey! Could you please review?

fedorov-xyz commented 3 months ago

Sure, I can do that. But what's the reason? When I install dependecies locally, both node_modules and lock file are highlighted as untracked files

image
fedorov-xyz commented 3 months ago

Done. Also fixed failed pipeline

ShogunPanda commented 3 months ago

Sure, I can do that. But what's the reason? When I install dependecies locally, both node_modules and lock file are highlighted as untracked files

image

I have it in my global .gitignore_global.

fedorov-xyz commented 3 months ago

Yeah, makes sense. In general it is good practice to locally host ignores, since third-party contributors may also work with the repository. Also, the repository should have a lock file with package versions, so that all contributors and CI have consistent behavior. What do you think?

ShogunPanda commented 3 months ago

I don't like to submit lockfile as they add a lot of problems when rebasing branches. I rely on semver adoption from packages maintainers.