Closed ElementalCrisis closed 4 years ago
@bigretromike I know most of these settings are in Server but have they been added to the API?
I'm thinking that one is future proof - but I will check it, in few minutes and tell you. (also cloning server take time ;-) )
API use model from here: https://github.com/japanesemediamanager/Shoko.Models/blob/3eb5e5c5b18b81a404b922d58c3c9895e9129f2b/Client/CL_ServerSettings.cs Anything there is supported by API.
So if they are in server (as they are) they should be in that model class (they are), and if they are they work :-)
@ElementalCrisis @bigretromike I was told by da3dsoul that changing db settings in a running server is a legacy thing and is a very bad thing in general so I don't think we will be adding that here.
Even if we do add it, it will probably be some Troubleshooting/Maintenance page.
changing idk, there need to be setting to enable wizard then something like FirstRun = True
.
Or changing setting would need to restart shoko server, there need to be way to change db settings somehow imo, somehow via wizard or by Troubleshooting/Maintenance page; Maybe it should store those information and re-run shoko so those setting take effect only then ? dunno.
But as long as we store most (almost all) settings in db, changing db info would equal to database wipe (with or without populated data), so restart is all right there.
Users will not be able to select MySQL or SQL Server during setup. You'll only see first run if it's never been run before.
there need to be mechanism to trigger it back, how you will change db when you got installed shoko ? removing programdata (windows) ? What more non-user friendly you want to do it ? ;-)
you are not supposed to change DB, we have no migration tools and everyone who tried to migrate ran into issues, so it is more of a troubleshooting step in case your server does not start up.
I really don't see how this is a setting.
its not about migrate, its more about to start fresh without needing to manually remove settings.json
All you would need to do is delete the .db3 file then. All the other settings can be changed in either the Web UI or Desktop.
Why db3 ? Do we store settings in db now ?:-)
On April 2, 2018 1:35:46 PM GMT+02:00, ElementalCrisis notifications@github.com wrote:
All you would need to do is delete the .db3 file then. All the other settings can be changed in either the Web UI or Desktop.
-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/ShokoAnime/ShokoServer-WebUI/issues/70#issuecomment-377912084
-- Sent from my Android device with K-9 Mail. Please excuse my brevity.
@bigretromike I don't think we store settings in DB, settings are stored in settings.json and before that in app config, i.e. ShokoServer.exe.config next to exe.
I know @hidden4003 but what the f.. is @ElementalCrisis talking about then? why I would want to delete .db3 (sqlite db) to wipe my db settings and set them again ?! I see that we didn't understand each other ...
Ah yeah I thought you were referring to your collection. I
Regardless, if a user wants to start fresh then they will have to delete settings,json. I don't want there to be a button to accidentally wipe your settings.
You just add 1 or 2 dialog boxes with yes/no with red text and that its. All system with webui got that... Also its already in server ui, so whats the problem ?
There is no button in current Server UI to wipe your settings. You can make changes which you can also currently do in Web UI.
there is to change db which is essentially wipe command (as @hidden4003 stated that migration is fail here); if its so problematic to make this in webui then its easier and give similar results to add "wipe"
That doesn't wipe your settings.json file, it just adds the new DB info to it. Like I said before I believe we don't need a wipe button as it serves no purpose.
Also you can change DB without any repercussions, I do it all the time. We've never supported migration from one DB type to another which is what @hidden4003 was referring to.
@ElementalCrisis no, he was reffering to channging db settings as its 'legacy' and wont add it.
No matter what Im against excluding db change settings in webui - its needed and forcing user to delete settings.json just to force "wizard" (so he can change db info) is stupid.
MySQL and SQL Server are no longer being offered as DB options and SQLite doesn't have any DB options. For users currently using MySQL and SQL Server they are going to have to manually edit the settings.json file to make changes if needed.
oh, thats something new. mkay
Is this implemented or its "near (never) future" plan ? because I don't recall seeing any commit about removing db support, or its just "You don't have option only SQLite, but if you need it you need manually edit settings.json and it will work".
Just asking
Plex is doing perfectly fine with sqlite so it discord and lots of other programs, even phpstorm uses sqlite db for keeping indexes for a project so we just need to migrate to EF or fix nhibernate so it would enable proper WAL mode and disable sync on every operation an it will be even faster.
Regarding settings page, messing with DB setting will make server unuasable, I don't want any of those on the settings page, these go to separate page that is called advanced settings or troubleshooting or whatever with a big warning that poking around in there may irreversibly damage config or make server unusable. If you manage to give it bad config with import settings server will be unable to start at all.
I total agree with you @hidden4003 I don't mind sqlite at all.
Most of the settings done so I think we release 0.3.4 together with upcoming server release.
This is just a general list so we know what needs to be added. As discussed a lot of settings from Desktop will be added so if unclear check the desktop settings section.
We should also work on improving the settings and not just copying them over.
Web UI Settings
Log Rotator