search

ShokoAnime / ShokoDesktop

Repository for Shoko Desktop
http://shokoanime.com/shokodesktop/
105 stars 25 forks source link

Icon Does Not Change When Pausing/Unpausing A Command #382

Closed ElementalCrisis closed 8 years ago

ElementalCrisis commented 8 years ago

Additionally, the text is shown in the OS language and not the selected language in JMM Server/JMM Desktop.

HOW TO REPRODUCE:

  1. Pause a command (Haher, AniDB, Image)
  2. Resume the paused command

EXPECTED BEHAVIOR: Icon should update to reflect current command status and wording should reflect selected language in JMM Desktop, not Windows.

hidden4003 commented 8 years ago

I tried fixing this.

  1. Buttons do work, they are just delayed until next server status update, so up to 4 sec. delay but I guess that is working as intended?
  2. I tried fixing the translations, but the value itself comes from the server. Server is sending text value and that value is used as is and I did just check that if you select server language as RU then you get RU status text in english client.
ElementalCrisis commented 8 years ago

I don't remember it taking as long as 4 seconds to update, best way would be to compare with an older release. The OS language is taking priority over the selected language, JMM in English yet status updating in German.

bainejmmdesktop

We had this problem before so I'm assuming something with the cache update changed our previous fix. I'll keep looking into it.

hidden4003 commented 8 years ago

I've made buttons more responsive. Now the bad part. As soon as you switch server language to non-English buttons break because they determine status by analyzing the text for a word "pause", in other locales there is no such word so button gets stuck in pause state indefinitely.

ElementalCrisis commented 8 years ago

Would adding those strings in JMM Desktop help?