ShokoAnime / ShokoDesktop

Repository for Shoko Desktop
http://shokoanime.com/shokodesktop/
105 stars 25 forks source link

Certain Filter Conditions Do Not Work #433

Closed ElementalCrisis closed 7 years ago

ElementalCrisis commented 8 years ago

Tested on 3.6

misakitchi commented 8 years ago

Its for the beta v3.6.0.1 right? I have same issue... :( Filter Tag "Not In/In" "18 restricted" is not working...

da3dsoul commented 8 years ago

Oh hey this exists

da3dsoul commented 8 years ago

Also, video quality

da3dsoul commented 8 years ago

@maxpiva just commit some fixes. Let's update or closed this

ElementalCrisis commented 8 years ago

Will do some testing and update with results.

da3dsoul commented 8 years ago

TVDb works

da3dsoul commented 8 years ago

Video quality kind of works, you can only select one with proper results. I'd like to be able to choose more than one and have it be treated as 'or'

da3dsoul commented 8 years ago

Removing Filter Conditions often does nothing. Editing tags, video quality, etc with lists of strings only takes two, and they are treated as 'and' rather than 'or'

da3dsoul commented 8 years ago

More strings can be added by hand with a keyboard rather than clicking in the list

da3dsoul commented 7 years ago

Okay, I think I've fixed several of these.

da3dsoul commented 7 years ago

Verified anything with csv style arguments now work.

ElementalCrisis commented 7 years ago

Any updates @da3dsoul?

da3dsoul commented 7 years ago

There are issues with almost all of the apply at series level versions of filters. If in apply at group mode, almost everything works now. Group equals doesn't work at all (you can't select groups properly). Anime Type works flawlessly. I think custom tags work now, but someone will need to double check. Haven't tested episode added. Has ... Link works. Tag filters work. Video quality works 100%. I think year is still broken, but the logic for that needs to be rewritten according to the functionality noted in drop scripts. (Summary: it'll be apply at series, and series will be included if they aired at any time in the year)

da3dsoul commented 7 years ago

Year is fixed now

da3dsoul commented 7 years ago

TvDB seems broken again.... Ugh

da3dsoul commented 7 years ago

Okay, TvDB works, and MovieDB works, the TvDB or MovieDB doesn't work

da3dsoul commented 7 years ago

Fixed TvDB, MovieDB, and Both

da3dsoul commented 7 years ago

@maxpiva the last of these (see op) are part of the desktop errors for filters

da3dsoul commented 7 years ago

Finally....fucking.....DONE!