ShokoAnime / ShokoDesktop

Repository for Shoko Desktop
http://shokoanime.com/shokodesktop/
105 stars 25 forks source link

Logical error that wipe out image collection #479

Closed bigretromike closed 8 years ago

bigretromike commented 8 years ago

When server and client use same image path and in client you go to: Settings > Community Site > Update Local Images The image collection is wipe out (from both server and client as they share path) and Client ask Server to send new one... As the server have not images because it share image folder there is a error while sending it.

This is error in current master.

da3dsoul commented 8 years ago

That's not a bug, it has a very obvious note

bigretromike commented 8 years ago

You know it work in different way for different paths ? for same path it wipe out collection without redownloading it for different paths it remove local collection and redownload it from server

If it by design then it should work one way or another...

bigretromike commented 8 years ago

Yes, you have right.. there is note which i missed. If this was design this way.. and the proper solution was to add note. fine. I close issue then

ofc, solution would be add checker if image path is same for server and client and skip force download, but probably adding note about the danger of it is better 👍

RickDB commented 8 years ago

Improved this behaviour in commit id a4c74f0e66f7475f9b29146947f8c886fffb76b1

It now hides the button and hint text in case image path equals server path, even with the hint text like before there's a change people don't read and kill their server image storage and this prevents that :)