search

ShokoAnime / ShokoDesktop

Repository for Shoko Desktop
http://shokoanime.com/shokodesktop/
105 stars 25 forks source link

Performace issues in 3.8 #563

Closed t0815 closed 3 years ago

t0815 commented 7 years ago

I have noticed a serious performance reduction since last update (3.8.0.0). The Client is very unresponsive and the main view (Dashboard) takes ~10 seconds to load up.

Also, when viewing details on a series, it takes much longer now, to load and display the data.

ElementalCrisis commented 7 years ago

Any errors in your Server or Desktop log? How big is your collection and what is the DB type?

A ton of work went into making Desktop faster to the point where I can load OP in 3-5 seconds where before it took a minimum of 2 minutes.

t0815 commented 7 years ago

I've got 2003 Series in DB. I am using mySQL Server Version 5,6 in performance Mode (Server Mode). What i noticed : Only first view takes very long. If i refresh the main-view or open a previously displayed details-page again, it loads up faster (caching then i guess). If i restart the client, its slow again and fast after 2nd view again.

da3dsoul commented 7 years ago

Mhmm I wonder if Plex contracts are used in some places they shouldn't be. Plex contracts are the only thing with a generate and cache on demand model

ElementalCrisis commented 7 years ago

@t0815 provide more detail please.

Whats the main-view? Are you referring to the dashboard and if so what version, regular or metro?

t0815 commented 7 years ago

Yes, i'm referring to the dashboard - in old, non-Metro View. I checked client-logs for errors, but desktop log looks fine.

Checked Server log too, there are some errors, which occur repeatedly:

[2017-09-30 04:21:39:669] Error|CommandRequest_TraktUpdateInfoAndImages.ProcessCommand => TraktTVHelper.GetShowInfoV2 => TraktTVHelper.SaveExtendedShowInfoV2 Error in TraktTVHelper.SaveExtendedShowInfo: System.ArgumentNullException: Value cannot be null. Parameter name: source at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable1 source, Func2 predicate) at Shoko.Server.Providers.TraktTV.TraktTVHelper.SaveExtendedShowInfoV2(TraktV2ShowExtended tvshow, List`1 seasons) in D:\Documents\GitHub\ShokoServer\Shoko.Server\Providers\TraktTV\TraktTVHelper.cs:line 1173

da3dsoul commented 6 years ago

Those errors are unrelated, but should probably have an issue for themselves in Server. I don't use Trakt, so I've never noticed them.

Regardless, I've not experienced any significant lag (by comparison, Desktop is still a mess).

ElementalCrisis commented 3 years ago

Issues related to specific version of user as they haven't been reported since.