search

ShokoAnime / ShokoDesktop

Repository for Shoko Desktop
http://shokoanime.com/shokodesktop/
105 stars 25 forks source link

Unintentional file deletion #604

Closed xmodx10 closed 2 years ago

xmodx10 commented 4 years ago

VERSION INFORMATION

Server Version: Daily (24/09/2020)

Desktop Version: 4.0.0.0

LOG FILE

-Desktop logs dont really show much -Docker console logs do not show anything

DESCRIPTION

Applies to when selecting to delete a file from either episode list or the "ignored" file list. May affect more areas as well.

You un-tick the "local file system" provider with the intention of it only deleting the record from the database, however it deletes the file!

image

STEPS TO REPRODUCE

See above

da3dsoul commented 4 years ago

Personally, I don't see why you'd want files existing that Shoko can handle outside of Shoko. This isn't a bug, actually. It's a poor design decision from when cloud was added. It was intended that you could delete it from local but not cloud or whatever. If the checkbox is unchecked in that case, the intended behavior is to do nothing.

xmodx10 commented 4 years ago

ah I see, so if un-ticketed its actually meant to do nothing at all. I'm having a look through the code and ill see if I can fix it up.

da3dsoul commented 4 years ago

On the server side, if you wanted to do what you're saying, you'd need to delete it, and then decide if you want it added to the ignored files list, as it'll just reimport on next scan

xmodx10 commented 4 years ago

Thanks, Understood. Though we still have a bug with this to some degree as it is deleting files even when the checkbox is not selected.

I’ll see if I can fix it up so it does nothing if the checkbox is not selected, OR we could just remove the checkboxes & provider list altogether and make it a simple yes/no dialog ?

What do you think, really there is now only 1 provider from what I can tell.

da3dsoul commented 4 years ago

I'm fine with removing it