Error when trying to install on D:\ drive

ShokoAnime / ShokoDesktop

Repository for Shoko Desktop

103 stars 24 forks source link

Error when trying to install on D:\ drive #618

Closed lsahnicne closed 2 years ago

lsahnicne commented 2 years ago

I am trying to install Shoko Desktop version 4.1.2. My system drive has a D:\ letter assigned to it. I leave the default destination in the installer "D:\Program Files (x86)\Shoko\Shoko Desktop" unchanged. Setup fails to complete with the following error: Setup was unable to create the directory "C:\ProgramData". I presume it assumes to be installed on C:\ drive despite destination being located on another drive.

ElementalCrisis commented 2 years ago

No, Shoko Desktop will be installed to your D drive, but it seems to fail when trying to create the ShokoDesktop folder inside the ProgramData folder.

I've never seen that error before, what verson of Windows are you running?

lsahnicne commented 2 years ago

It appears to be looking for the ProgramData folder in the wrong place then. At the time of installation attempt, my PC did not even have any drive mounted as C:\ . Is this path "C:\ProgramData" hard-coded into installation program rather than %PROGRAMDATA% environment variable? I run Windows 7 SP1 x64.

Cazzar commented 2 years ago

Looks to be https://github.com/ShokoAnime/ShokoDesktop/blob/5a235ac51b284ec5e695d5a4ad02465f86e5b64f/Installer/ShokoDesktop.iss#L55

ElementalCrisis commented 2 years ago

I updated the install script and uploaded new install builds.

Give it a go @lsahnicne.

lsahnicne commented 2 years ago

Installed successfully this time.

ElementalCrisis commented 2 years ago

Awesome, closing ticket.