search

ShokoAnime / ShokoServer

Repository for Shoko Server.
http://shokoanime.com/shoko-server/
MIT License
386 stars 75 forks source link

Default Renamer Does Not Rename Subtitle Files #1001

Closed ElementalCrisis closed 1 year ago

ElementalCrisis commented 1 year ago

VERSION INFORMATION

Server Version: 4.1.2 Desktop Version: 4.1.2

DESCRIPTION

As mentioned on Discord, the default renamer does not rename sub files in the same folder, it does apparently rename them on move per @da3dsoul but I did not test this.

STEPS TO REPRODUCE

Rename a series that has external sub files.

Mik1ll commented 1 year ago

I haven't tested lately, but there is logic to rename them here. This relies on mediainfo reading files with the same base name in the folder for textstreams here. A problem I found a long time ago was that mediainfo could not handle subtitle files with some encodings, causing it to fail to detect the text streams and ignore the files. This may be the reason. I believe that a dumber file extension based approach may be more appropriate here.

ElementalCrisis commented 1 year ago

Yeah just seems like a bug at this point. Wanna give it a go and see if you can fix it?