search

ShokoAnime / ShokoServer

Repository for Shoko Server.
http://shokoanime.com/shoko-server/
MIT License
386 stars 75 forks source link

File_Source DB Migrations #1007

Closed krbrs closed 1 year ago

krbrs commented 1 year ago

Added DB migrations for File_Source to make already present entries consistent with currently inserted values. Please let me know if I forgot something. Also, if somebody could test the migrations for other DBs than MariaDB that would be great!

da3dsoul commented 1 year ago

That was an oversight, rather than intended behavior. After thinking on it, though. I do at least want them to match. I'm still torn on whether I want the database model to be bound directly to the Enum. It would make a lot of things more simple

revam commented 1 year ago

I'm in favor of the database model being directly tied to the enum(s). Also, we don't need to be strictly using anidb's terminology either.

da3dsoul commented 1 year ago

Ok after some thought, for now, we will take this. (thank you). We will wait an making it an enum in the database model, only because Desktop is dependent on that, and I don't want to fix it. When we merge/separate Commons and Models, then it can be done