Closed revam closed 1 year ago
Feel free to point out my mistakes (if any).
I'm converting this to a draft for now. After some more thinking did I remember that the image paths stored in AnimeStaff
table is always empty for the staff members that are not VAs because the image paths are not included in the HTTP XML files and we haven't downloaded the data from the UDP API (yet).
I'm keeping this PR open since I intend to add the udp commands to download the missing data and also do some refactoring on the Anidb_Seiyuu
table. Mainly renaming it to AniDB_Creator
since it will be not just VAs anymore and also adding the creator type ('person', 'collaboration' or 'company' iirc). It will be easy to migrate for the existing VAs since they're always of type 'person'. The creator type is good to know mainly to distinguish between the studios (of type 'company') and staff members — both VAs and non-VAs — (of type 'person' or 'collaboration').
Sounds good
As I said (in the updated) description, a second PR is coming for the staff data. Meanwhile I'll use this PR for the image refactor.
Fixed the merge conflicts from the settings rewrite.
I don't see any glaring issues. As long as it's tested, it's fine
Modernize the image commands. A second PR to add staff data and staff images are incoming.
Changes in this commit/PR
Modernized and simplified the image commands (by my standards if that is anything to go by man_shrugging).
Tried to reduce duplicate code where possible, without rewriting the whole system.
Updated Shoko.Commons to modify the get image format helper function used in this PR. The master branch for Shoko.Commons needs to be moved accordingly afterwards.