ShokoAnime / ShokoServer

Repository for Shoko Server.
http://shokoanime.com/shoko-server/
MIT License
386 stars 75 forks source link

refactor: update image commands #1024

Closed revam closed 1 year ago

revam commented 1 year ago

Modernize the image commands. A second PR to add staff data and staff images are incoming.

Changes in this commit/PR

revam commented 1 year ago

Feel free to point out my mistakes (if any).

revam commented 1 year ago

I'm converting this to a draft for now. After some more thinking did I remember that the image paths stored in AnimeStaff table is always empty for the staff members that are not VAs because the image paths are not included in the HTTP XML files and we haven't downloaded the data from the UDP API (yet).

I'm keeping this PR open since I intend to add the udp commands to download the missing data and also do some refactoring on the Anidb_Seiyuu table. Mainly renaming it to AniDB_Creator since it will be not just VAs anymore and also adding the creator type ('person', 'collaboration' or 'company' iirc). It will be easy to migrate for the existing VAs since they're always of type 'person'. The creator type is good to know mainly to distinguish between the studios (of type 'company') and staff members — both VAs and non-VAs — (of type 'person' or 'collaboration').

da3dsoul commented 1 year ago

Sounds good

revam commented 1 year ago

As I said (in the updated) description, a second PR is coming for the staff data. Meanwhile I'll use this PR for the image refactor.

revam commented 1 year ago

Fixed the merge conflicts from the settings rewrite.

da3dsoul commented 1 year ago

I don't see any glaring issues. As long as it's tested, it's fine