ShokoAnime / ShokoServer

Repository for Shoko Server.
http://shokoanime.com/shoko-server/
MIT License
376 stars 74 forks source link

Series Without a Japanese Trascription for the Main Title are Unsearchable #1046

Closed natyusha closed 1 year ago

natyusha commented 1 year ago

VERSION INFORMATION

Latest (https://github.com/ShokoAnime/ShokoServer/commit/253918fa65702019677d4f4494567f37122e22bd)

DESCRIPTION

Series which do not have an x-jat Main Title on AniDB do not show up in searches. In practice, this means that anything that has a Main Title which is a Korean (x-ko), Chinese (x-zht). or Unknown (unk) transcription won't show up unless searching for synonyms instead of the main title. This causes various issues such as auto matching failing in Plex if using the Main Title and not a Synonym or series being harder to find in Desktop.

STEPS TO REPRODUCE

  1. Find a series without a Japanese transcription for the title.
  2. Attempt to search for it in Desktop or through the API (using the main title and not a synonym).

A few examples of series that meet the above criteria are linked below:

https://anidb.net/anime/12560 https://anidb.net/anime/12843 https://anidb.net/anime/15683

EXAMPLE

Using 'Wu Shan Wu Xing' as an example running the search below will not return any results for the series:

/api/v3/Series/AniDB/Search/Wu%20Shan%20Wu%20Xing?includeTitles=true&pageSize=1&page=1

WORKAROUND

For series that are effected by this issue one can simply search for a synonym to find it. Using 'Wu Shan Wu Xing' as an example once again; but instead searching for the synonym 'Fog Hill of Five Elements' the series will show in the search.

/api/v3/Series/AniDB/Search/Fog%20Hill%20of%20Five%20Elements?includeTitles=true&pageSize=1&page=1

da3dsoul commented 1 year ago

Interesting. We can add some fallbacks. I didn't even know x-ko existed

natyusha commented 1 year ago

Now that you mention it x-ko might not actually be used since i'm looking through here: South Korean production and it seems like they are all just set to unk

revam commented 1 year ago

English and romanji should be searchable, plus any language in the user's global language preference.

@natyusha can you try to add Korean transcription in the language preference then searching for the title?

natyusha commented 1 year ago

I don't see Korean (or Chinese) transcription as an option to add to the language settings. But that wouldn't matter anyways as shows using Korean transcriptions seem to be set to unk (as mentioned here)

revam commented 1 year ago

@natyusha Add unk (and any other languages like x-zh) to your preferred languages list in the json settings (or select them in the list in the web ui or desktop) and it should work… I hope.

revam commented 1 year ago

Actually, the main title is always added to the searchable titles for the series now, so you might not need to do that to search for the main title.

revam commented 1 year ago

So searching for the main title is working in the latest daily, regardless of the language preference set in the settings.

E.g. searching for the example used in the OP in v2 and v3 (which both uses the same internals now); image image image