search

ShokoAnime / ShokoServer

Repository for Shoko Server.
http://shokoanime.com/shoko-server/
MIT License
376 stars 74 forks source link

Shows in WebUI (during manual link) are shown with Episode Numbers which are normal Episodes + Specials #1047

Closed Baine closed 1 year ago

Baine commented 1 year ago

VERSION INFORMATION

Server Version: 837c647

WebUI Version: aa89c9c

LOG FILE

nothing to see here

DESCRIPTION

Conversation between @ElementalCrisis and myself regarding this

Baine — heute um 17:56 Uhr also I'd be a big fan of indicating the actual number of eps, when selecting the show, and not all counted together or something Like "1 (1)", meaning one episode, 1 special just linked a movie and was confused because it showed 2 episodes for it Elemental Crisis — heute um 17:57 Uhr Movie? Baine — heute um 17:57 Uhr Given - The Movie (2020) Elemental Crisis — heute um 17:57 Uhr Sounds like a split movie Baine — heute um 17:57 Uhr nope image image Elemental Crisis — heute um 17:59 Uhr I only see 1 "episode" for it. Baine — heute um 17:59 Uhr the above is in webui Baine — heute um 17:59 Uhr the below is on anidb

Old Desktop already makes the count more visible: image image

STEPS TO REPRODUCE

  1. Have show, movie, whatever with normal episodes and specials
  2. Try to add files to that show in the unrecognized utility in webui
  3. be irritated by the difference in numbers
revam commented 1 year ago

I'll look at it tomorrow.

ElementalCrisis commented 1 year ago

Revisiting this issue, it's not a bug per say but a way the data is displayed.

Currently, Desktop doesn't even show the count or type, just the name and AniDB ID. Web UI only shows the count and type if it has the info, otherwise it just shows a dash - instead.

image

We can either remove the count altogether or leave it how it is.

revam commented 1 year ago

So we can just close it?

Since i think we can show both the normal and special counts, provided we have the anidb entry locally, and also modify the anidb model to return them separately, since they exist separately and combined in the database and internal model.

ElementalCrisis commented 1 year ago

I think the total count is fine, we can just make it show the total number of episodes.