search

ShokoAnime / ShokoServer

Repository for Shoko Server.
http://shokoanime.com/shoko-server/
MIT License
376 stars 74 forks source link

Images pulled from MovieDB inaccessible from desktop app #1072

Closed Altereno closed 6 months ago

Altereno commented 1 year ago

VERSION INFORMATION

Server Version: Daily with Docker

Desktop Version: Daily

LOG FILE

System.NullReferenceException: Object reference not set to an instance of an object. at Shoko.Server.Providers.MovieDB_Movie_Result.Populate(Movie movie, ImagesWithId imgs) in /usr/src/app/source/Shoko.Server/Providers/MovieDB/MovieDB_Movie_Result.cs:line 31: System.NullReferenceException: Object reference not set to an instance of an object. at Shoko.Server.Providers.MovieDB.MovieDB_movie_Result.Populate(Movie movie, ImagesWithId imgs) in /usr/src/app/source/Shoko.Server/Providers/MovieDB/MovieDB_movie_Result.cs:line 31

DESCRIPTION

Fanart pulled from the MovieDB have no preview, and are not able to be opened by the desktop app. Syncing the images to Jellyfin shows that the some of the images pull are not related to the series. Pressing the update MovieDB images button on a specific series on the desktop app results in an error in the logs.

Screenshot 2023-06-23 142306 Screenshot 2023-07-14 165759

STEPS TO REPRODUCE

Import a series with a MovieDB link.

ElementalCrisis commented 6 months ago

@revam tagging you just for consideration for your TMDB PR.

harshithmohan commented 6 months ago

@revam tagging you just for consideration for your TMDB PR.

It's a desktop only issue, do we really need to consider it?

ElementalCrisis commented 6 months ago

More for just keeping in mind when grabbing images from TMDB.

revam commented 6 months ago

i fixed up all tmdb v1 endpoints for backwards compatibility, so if it just relies on shoko server to function then it should work. it shouldn't be an issue.. next year.