search

ShokoAnime / ShokoServer

Repository for Shoko Server.
http://shokoanime.com/shoko-server/
MIT License
374 stars 74 forks source link

Rename OriginalFilename #1116

Closed Mik1ll closed 2 months ago

Mik1ll commented 2 months ago

Original filename is not representative of the string's meaning. The original is not returned by AniDB api, an internal version of the filename is

Cazzar commented 2 months ago

I was about to comment... I am not sure that Filename in this case is even accurate given the original description.

Cazzar commented 2 months ago

Also, given that it's an API break, you want more than just updating the build metadata @revam @Mik1ll

revam commented 2 months ago

will it be fine to add the original field back as an obsolete field to avoid the api breakage? Also, if FileName isn't enough, should it be appended by 'Internal' or something similar?