search

ShokoAnime / ShokoServer

Repository for Shoko Server.
http://shokoanime.com/shoko-server/
MIT License
374 stars 74 forks source link

Change/feature request - Sorting of Groups in Webui file summary endpoint #1130

Closed fearnlj01 closed 1 month ago

fearnlj01 commented 1 month ago

Raising this as something to address in the future on @ElementalCrisis's request.

What/Why

In the /WebUI/Series/{seriesID}/FileSummary endpoint, you can end up with groups coming in containing Special type episodes only before that of regular episodes, or mixed episode type groups as per the following screenshot.

I would suspect that it makes more sense for the ordering to be addressed serverside rather than by re-sorting the response, hence raising this on Server & not in the WebUI.

image

Resolution

I would expect that the desired sorting could probably be attained by ordering the result groups (as set in /Shoko.Server/API/v3/Models/Shoko/WebUI.cs) by the count of included episodes, then the count of included specials, and so on.

As to if this is a good idea or not, I suspect not, but it's 'something' to consider rather than nothing at least!

revam commented 1 month ago

@fearnlj01 @ElementalCrisis

You do know that the groups can contain episodes across types, right? The screenshot @fearnlj01 provided may make the viewer believe that is not possible, but it is. Now if one of you can mange to define the rules you want in plain English then I can turn it into code (if the rules you define aren't too complicated).

ElementalCrisis commented 1 month ago

Oh I provided an example but looks like it wasn't included.

Episodes Episodes Specials Specials

If we're tracking type other here as well, since originally, we were not then add that after specials.

And just to be clear, this is purely for sorting purposes. In the image provided, both episodes would be listed first and then specials.

revam commented 1 month ago

Closed by 81f21870b7dbc03866f876e0c946985487c21db6