ShokoAnime / ShokoServer

Repository for Shoko Server.
https://shokoanime.com/
MIT License
404 stars 74 forks source link

Recommendations to download recommends already watched and voted for series #274

Open SL-Gundam opened 8 years ago

SL-Gundam commented 8 years ago

Before i started using JMM i of course watched anime and voted after finishing them

Now i'm using JMM

One example (i could provide more but whats the use) The recommendations for download suggests i download Seirei no Moribito because of Juuni Kokuki. I've already watched and deleted Seirei no Moribito years ago. I've also voted for it. JMM seems to know this vote when i go to Utilities -> My Votes

So why is it still recommending i download it?

ElementalCrisis commented 8 years ago

JMM recommendations are based off the similar anime section on AniDB. It shows all of them regardless if you already have them in your collection or in your case if you've already voted for them. I brought this up before in https://github.com/japanesemediamanager/jmmclient/issues/210 and it seem the best course of action would be to either make the series you've already voted for or already have a colored background or grayed out.

SL-Gundam commented 8 years ago

a perma vote means you've watch it imo. So i would prefer that one

ElementalCrisis commented 8 years ago

Taking it a bit further, a grayed out series would mean you've already submitted a perma vote for it while a series with a colored background would mean it's in your collection or you've given it a temporary vote.

ElementalCrisis commented 10 months ago

Ideally a recommendation system that didn't rely on AniDB would work best since a lot of users don't really vote.