bigretromike
commented
8 years ago The move from XML to JSON is a good thing. Also I understand that you want split this:
for int = 0; i++; i < 10
{
command[i].execute();
}to :
command[0].execute();
command[1].execute();
...
command[9].execute();?
Do we have errors because of half done task being run after restart? Maybe better (less cpu/time consuming) would have each command had it ID (PID) and have like last 1000 command executed in db so when you run half done command you would check againts list of done commands?
Also the conversion wont resolve situation when command will be converted to list of commands and someone shutdown jmm in middle - or you wont save in middle state of process and restart it from begining?
Do we know how big those iteration commands can get?
ElementalCrisis
t3hk0d3
da3dsoul
Update Command Request from
We add the following
CommandRequest Interface will only have the Process Method.
A BaseCommandRequest child class could be made with helper functions, like populating the command request data initial values.
CommandRequest will extended into the commands we have today as childrens of CommandRequest or BaseCommandRequest, the child classes could have any number of extra properties to function. We use json.net to serialize the Child class commandrequest, and store it in CommandDetails, we do that in the save function of the repository, we clear CommandDetails then we serialize the object into CommandDetails using JSON.NET serializationSettings (TypeNameHandling=Auto) that will serialize the object with the correct children type. On CommandRequest retrieval from the database, we deserialize and return the deserializer child object instead the original Plain CommandRequest entity.
Any jmmserver worker should be split in two parts, the batch part (foreach, for, etc). and convert the loop part items into a commandrequests.
Off course a Thread Dispatcher should be made. And a good API to obtain information for the global status, group status, running requests, etc.
Any thoughts?