ShokoAnime / ShokoServer

Repository for Shoko Server.
http://shokoanime.com/shoko-server/
MIT License
386 stars 75 forks source link

trakt rework/update overview #525

Open CuddleBear92 opened 7 years ago

CuddleBear92 commented 7 years ago

This is a writeup and overview of what is needed/wanted of trakt going forward. Here is the link to the trakt api: http://docs.trakt.apiary.io/

once alot of the syncing and metadata functions are up and running it can mean it could take the place of tvdb as the main metadata agent outside of anidb.

Metadata

Syncing

Small syncs should be done often. on client startup (maybe check since last opened so it doesnt sync if you started the client 5 times within the hour) Sync on start up (of client not server) + once a day is what they talk about on the trakt api site.

Fixes

Updates

Issues trakt could fix

bigretromike commented 7 years ago

I must say, impressive issue :-)

RickDB commented 7 years ago

Great overview 👍 , will start fixing the bugs and #512 should be fixed now. Movie linking (#49) I'm not sure how reliable Trakt is with anime movies but gonna try.

ElementalCrisis commented 7 years ago

I think the focus should be fixing the Trakt related bugs for now and hold off on everything else until a later date as we're currently working on multiple things. I'd also like to see Trakt user statistics to determine the priority level of adding these Trakt features to Shoko.

I'm also not sold on making Trakt the main source of metadata when there's no point in changing our metadata sources. We already pull from AniDB and TvDB and it covers 99% of our needs, what else info could we possibly need besides adding feature creep. We don't support those other sites you mentioned and I don't think we need to either.

A lot of this requires the user to be a Trakt member. It's a known fact that you lose users when making a user register to use a product, we need them to be an AniDB member so that's unavoidable but we don't need them to be a Trakt user.

Nonetheless thre are some good ideas in this issue but we've got hundreds of issues with good ideas that we need to sort through and determine priority.

RickDB commented 7 years ago

Agree, especially since Trakt is basically an extension of other sources we already support and no longer offers images it has become less useful for metadata at least. What I do like is the comments / ratings system they have there but we also have that with AniDB so it doubles a bit.

Once we can confirm sync and scrobble fully working we can look at this at a later time for sure as we got a lot on our plate already :)

da3dsoul commented 1 year ago

...I was looking at Trakt with Kero.... Didn't realize this exists. Well, this may be bumped up in priority, as the xrefs for TMDB will be very useful

da3dsoul commented 1 year ago

A lot of this is already done. It just needs a place to be stored in the DB, and another api call for episodes needs to be added. It just needs some cleanup, better API, and a place in the webui for the long term

ElementalCrisis commented 8 months ago

@da3dsoul update on this? Also @krbrs I know you use Trakt, can you verify these issues please.

da3dsoul commented 8 months ago

I'm kind of meh on it, but I don't use trakt

krbrs commented 8 months ago

@ElementalCrisis going to add things I noticed (e.g. Trakt link PIN refreshing too fast to auth it) when the new year is a few days old

krbrs commented 8 months ago

New Tasks aside from the above, which are still all "TBD". This is still incomplete

Current issues I could reproduce:

harshithmohan commented 8 months ago

New Tasks aside from the above, which are still all "TBD". This is still incomplete

Current issues I could reproduce:

  • [ ] Trakt Device PIN refreshes too fast to auth it using WebUI. Re-checking if auth was successful needs to be throttled more than 1 second (best about 1-2 min.) to prevent issuing a new PIN before you had a chance to enter it.
  • [ ] When removing Trakt in Settings, the Device Token, date, etc. is not removed automatically. Currently this needs to be done by hand in settings json if you want to redo the auth
  • [ ] Scrobbling throws "conflict" errors, this needs to be handled better. Files that are completely played should not send another play to Trakt if the last play for the file is less than x min. ago
  • [ ] Sync does not import from Trakt. This seems to be "intended behavior" from what I read here. It was assumed Shoko would be the leading database. There should be a setting if you want to overwrite or import/sync watched states to Shoko

First two are fixed in https://github.com/ShokoAnime/Shoko-WebUI/pull/771